Tile load event #5628
Merged
Tile load event #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggetz can you test and review this? |
ggetz
reviewed
Jul 14, 2017
| tile.contentReadyPromise.then(function() { | ||
| removeFunction(); | ||
| tileset.tileLoad.raiseEvent(tile); | ||
| }).otherwise(removeFunction); |
There was a problem hiding this comment.
Since it looks like this can fail, would it be worth passing an error to the event?
There was a problem hiding this comment.
We would probably add a tileFailed event instead, a little more detail here: #5158
|
Other than that one comment, looks good. |
|
I want to keep this open for just a little longer, currently getting feedback on the forum. |
|
There hasn't been too much activity on the forum post so I think this should go in before the release and if needed tweaked later. @pjcozzi can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5627